Native multiarch support with backwards compatibility to osrf images by Crola1702 · Pull Request #1120 · ros-infrastructure/ros_buildfarm

Crola1702 · 2026-01-30T17:12:47Z

No description provided.

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

claraberendsen · 2026-02-02T13:57:29Z

ros_buildfarm/scripts/misc/docker_pull_baseimage.py

+    if base_image.startswith('arm64v8/'):
+        platform_flag = 'linux/arm64'


Do we need this flag even if the image is already targeting the correct architecture?
I believe docker should be able to fetch the correct image based on the host OS.
If you do docker run -it ubuntu:noble uname -m it will automatically download the correct image if we are not doing cross-compilation.

claraberendsen · 2026-02-02T14:28:37Z

For the transition to using the native multi arch docker images the main things we should provide are:

Use the correct docker image for the base OS when we are not using qemu. That should be as simple as fetching the ubuntu:noble image from the correct agent.
Allow backwards compatibility for the older images noble and before. That should be a flag that could be --legacy-multi-arch or something as to have a path to what was working.
For resolute onward use the native docker --platform to signal that we want to emulate the other architecture. If qemu is already installed and configured properly on the host --platform should suffice to indicate.

I think is a topic of discussion if we want this to be a flag the user has to set for the job to use emulation or if we want ros_buildfarm to work smarter and detect the arch drift and set the correct docker args.

claraberendsen · 2026-02-02T14:29:31Z

ros_buildfarm/scripts/release/create_binarydeb_task_generator.py

    add_argument_dockerfile_dir(parser)
    add_argument_env_vars(parser)
    add_argument_skip_tests(parser)
+    parser.add_argument(


We should invert this argument and set the new way as default with a specific argument to fallback to the previous ways.

claraberendsen · 2026-02-02T14:33:34Z

ros_buildfarm/templates/snippet/builder_check-docker.xml.em

+if arch in ['i386', 'armhf', 'arm64'] and not vars().get('use_official_docker_images', False):
    base_image = 'osrf/%s_%s:%s' % (os_name, arch, os_code_name)
+elif arch == 'arm64' and vars().get('use_official_docker_images', False):
+    base_image = 'arm64v8/%s:%s' % (os_name, os_code_name)


Even though this naming is correct I think it's unnecessary since in modern docker the architecture resolution is done based on the image pull.

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Partially generated using Gemini 3.0 Pro Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 · 2026-02-09T16:34:22Z

So, with the last changes, I have the following results for amd and arm

amd64 (my workstation)

Running:

python3 -m ros_buildfarm.scripts.release.generate_release_script https://raw.githubusercontent.com/ros2/ros_buildfarm_config/refs/heads/ros2/index.yaml rolling default ament_package ubuntu noble amd64 > amd64_job.sh

amd64_job.sh
amd64_build_log.txt

arm64 (testfarm agent)

Running:

python3 -m ros_buildfarm.scripts.release.generate_release_script https://raw.githubusercontent.com/ros2/ros_buildfarm_config/refs/heads/ros2/index.yaml rolling unv8 ament_package ubuntu noble arm64 > arm64_job.sh

arm64_job.sh
arm64_build_log.txt

Note in job.sh that ros_buildfarm generates --platform=linux/arm64 but also --platform=linux/armv8. Not completely sure why, but it seemed to work, as you can see in the build_log.

What I think I'm missing is the possibility of using osrf/ubuntu_{arch}:noble images.

I added --docker-image-prefix, so we can do something like osrf/ubuntu:noble instead. However, I'm not sure how to put the architecture in-between, as using --docker-image-prefix osrf/ubuntu_arm64: results in osrf/ubuntu_arm64:ubuntu:noble image 🤔

Looking for another review and ideas now @cottsay @claraberendsen

Crola1702 · 2026-02-10T15:30:19Z

@claraberendsen suggestion:

--docker-image-prefix is os_code by default. So --docker-image-prefix is actually the whole image.
To keep in mind: in buildfarm_tools_config we should specify --docker-image-prefix osrf/ubuntu_{arch} so that we keep backwards compatibility
We should configure a job in the test farm to check if everything is working correctly

Maybe we can do instead (as we're not actually doing a prefix, but the image without the tag):

- --docker-image-prefix
+ --docker-image

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 · 2026-02-11T13:47:03Z

With the current changes now running:

python3 -m ros_buildfarm.scripts.release.generate_release_script https://raw.githubusercontent.com/ros2/ros_buildfarm_config/refs/heads/ros2/index.yaml rolling unv8 ament_package ubuntu noble arm64 --docker-image-prefix osrf/ubuntu_arm64 > job.sh

arm64_job.sh
arm64_build_log.txt

ros_buildfarm/scripts/misc/docker_pull_baseimage.py

ros_buildfarm/scripts/release/create_binarydeb_task_generator.py

ros_buildfarm/templates/release/deb/binarypkg_create_task.Dockerfile.em

ros_buildfarm/templates/snippet/builder_check-docker.xml.em

ros_buildfarm/templates/snippet/from_base_image.Dockerfile.em

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

ros_buildfarm/templates/snippet/builder_check-docker.xml.em

Co-authored-by: Scott K Logan <logans@cottsay.net>

ros_buildfarm/argument.py

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 added 4 commits January 30, 2026 09:09

Use official docker images as flag

cb69038

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Use arguments to pass arguments

6c2ad89

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Use platform in docker pull

d0720d6

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Use arguments file to pass arguments

73a8a7e

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 requested review from claraberendsen and cottsay January 30, 2026 17:12

claraberendsen reviewed Feb 2, 2026

View reviewed changes

Crola1702 added 2 commits February 3, 2026 09:57

Update argument to --docker-image-prefix

b2b7f1d

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Enable --platform flag in the templates using arch variable

09003fe

Partially generated using Gemini 3.0 Pro Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 added 2 commits February 10, 2026 10:48

Use whole docker image instead of prefix

bf4d414

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Extra tests commits

180de85

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 marked this pull request as ready for review February 11, 2026 13:47

Crola1702 changed the title ~~[WIP] Multiarch support~~ Native multiarch support with backwards compatibility Feb 11, 2026

Crola1702 changed the title ~~Native multiarch support with backwards compatibility~~ Native multiarch support with backwards compatibility to osrf images Feb 11, 2026

cottsay requested changes Feb 11, 2026

View reviewed changes

Crola1702 added 3 commits February 12, 2026 10:25

Alphabetize imports

1c2a44e

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Address logic PR comments

3877b1b

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Syntax fix

2cfac7a

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

cottsay reviewed Feb 13, 2026

View reviewed changes

ros_buildfarm/templates/snippet/builder_check-docker.xml.em Outdated Show resolved Hide resolved

Update ros_buildfarm/templates/snippet/builder_check-docker.xml.em

e92c1cf

Co-authored-by: Scott K Logan <logans@cottsay.net>

cottsay reviewed Feb 13, 2026

View reviewed changes

ros_buildfarm/argument.py Show resolved Hide resolved

Crola1702 added 2 commits February 19, 2026 08:29

Please flake8

8996dc1

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Use old images for old os codenames

d4e56da

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Crola1702 requested a review from cottsay February 19, 2026 15:08

Crola1702 requested a review from claraberendsen February 19, 2026 15:08

Fix condition to use old images only on specific arch

51eaf1c

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native multiarch support with backwards compatibility to osrf images#1120

Native multiarch support with backwards compatibility to osrf images#1120
Crola1702 wants to merge 15 commits intomasterfrom
Crola1702/multiarch-support

Crola1702 commented Jan 30, 2026

Uh oh!

claraberendsen Feb 2, 2026 •

edited

Loading

Uh oh!

claraberendsen commented Feb 2, 2026

Uh oh!

claraberendsen Feb 2, 2026

Uh oh!

claraberendsen Feb 2, 2026

Uh oh!

Crola1702 commented Feb 9, 2026

Uh oh!

Crola1702 commented Feb 10, 2026 •

edited

Loading

Uh oh!

Crola1702 commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if base_image.startswith('arm64v8/'):
		platform_flag = 'linux/arm64'

Conversation

Crola1702 commented Jan 30, 2026

Uh oh!

claraberendsen Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claraberendsen commented Feb 2, 2026

Uh oh!

claraberendsen Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

claraberendsen Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Crola1702 commented Feb 9, 2026

Uh oh!

Crola1702 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Crola1702 commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

claraberendsen Feb 2, 2026 •

edited

Loading

Crola1702 commented Feb 10, 2026 •

edited

Loading